Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfstest fixes with upstream as a target #2778

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

sacsant
Copy link
Contributor

@sacsant sacsant commented Mar 20, 2024

With upstream as a target following failures are observed

  • inih header file dependency during xfsprogs code compilation
  • local.config file not found

This 2 patch series fixes these problem.

Signed-off-by: Sachin Sant [email protected]

@sacsant
Copy link
Contributor Author

sacsant commented Mar 20, 2024

inih-devel header dependency failure

(1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: STARTED
(1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: ERROR: Command 'make' failed.\nstdout: b"libtoolize -c -i -f\nlibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.\nlibtoolize: copying file './config.guess'\nlibtoolize: copying file './config.sub'\nlibtoolize: copying file './install-sh'\nlibtoolize: ... (5.46 s)
RESULTS : PASS 0 | ERROR 1 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@sacsant
Copy link
Contributor Author

sacsant commented Mar 20, 2024

local.config file not found error

(1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: ERROR: stat: path should be string, bytes, os.PathLike or integer, not NoneType (23.60 s)

@sacsant
Copy link
Contributor Author

sacsant commented Mar 21, 2024

@PraveenPenguin @abdhaleegit should I resubmit this after the Travis check issue is resolved?

@PraveenPenguin
Copy link
Member

Yes @sacsant it is fixed , can you please resend the request

@sacsant sacsant force-pushed the xfstest branch 2 times, most recently from b497387 to 99f5795 Compare March 21, 2024 08:32
@sacsant
Copy link
Contributor Author

sacsant commented Mar 23, 2024

Test results after the fix:

w/64k page size + upstream
(1/1) /home/upstreamci/avocado-fvt-wrapper/tests/avocado-misc-tests/fs/xfstests.py:Xfstests.test;run-fs_type-fs_xfs_64k-loop_type-run_type-upstream-8427: FAIL: One or more tests failed. Please check the logs. (1992.76 s)

w/4k page size + upstream
(1/1) /home/upstreamci/avocado-fvt-wrapper/tests/avocado-misc-tests/fs/xfstests.py:Xfstests.test;run-fs_type-fs_xfs_4k-loop_type-run_type-upstream-7617: FAIL: One or more tests failed. Please check the logs. (1704.97 s)

Using upstream as a target to compile xfsprogs code, following
failure is encountered:

Command 'make' failed.\nstdout: b"libtoolize -c -i -f\nlibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.\nlibtoolize: copying file './config.guess'\nlibtoolize: copying file './config.sub'\nlibtoolize: copying file './install-sh'\nlibtoolize: ... (5.46 s)

Add inih-devel package as dependency so that this package will be
installed.

Signed-off-by: Sachin Sant <[email protected]>
With upstream as a target, xfstest test fails to copy local.config

(1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: ERROR: stat: path should be string, bytes, os.PathLike or integer, not NoneType (23.60 s)

This happens since teststmpdir directory is changed during compilation
of upstream code (various progs).

Move the stub before the upstream as a target check stanza to avoid
this failure.

Signed-off-by: Sachin Sant <[email protected]>
@PraveenPenguin
Copy link
Member

@disgoel can you please review this PR

Copy link
Contributor

@disgoel disgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sacsant does it not fail on suse for inih dependency

@sacsant
Copy link
Contributor Author

sacsant commented Mar 27, 2024

@sacsant does it not fail on suse for inih dependency

For SUSE libinih-devel is begin installed and is taken care.

Copy link
Contributor

@disgoel disgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In case a certain package install operation fails, the test fails
with a completely different message

ERROR: 'Xfstests' object has no attribute 'scratch_mnt' (15.37 s)

The package install function is called before various variable
initialization. In case of install fail, test errors out due
to usage of uniniitalized variables in teardown.

Move the package install function call post variable initialization

Signed-off-by: Sachin Sant <[email protected]>
On SUSE some of the packages used by xfstest script are available
with a different name.

Update the __setUp_packages function accordingly to use the correct
package names.

Signed-off-by: Sachin Sant <[email protected]>
@sacsant
Copy link
Contributor Author

sacsant commented Mar 27, 2024

I have added couple of fixes to address issues found when package install fails

commit 144455c addresses following issue when a package installation fails

Before fix:
(1/1) fs/xfstests.py:Xfstests.test;run-fs_type-fs_xfs_4k-loop_type-run_type-upstream-7617: STARTED
(1/1) fs/xfstests.py:Xfstests.test;run-fs_type-fs_xfs_4k-loop_type-run_type-upstream-7617: ERROR: 'Xfstests' object has no attribute 'scratch_mnt' (15.37 s)

After fix:
(1/1) fs/xfstests.py:Xfstests.test;run-fs_type-fs_xfs_4k-loop_type-run_type-upstream-7617: STARTED
(1/1) fs/xfstests.py:Xfstests.test;run-fs_type-fs_xfs_4k-loop_type-run_type-upstream-7617: CANCEL: Fail to install openssl-devel required for this test. (0.49 s)

Fourth commit adjusts package dependency to suit naming convention of various distro releases.

@PraveenPenguin PraveenPenguin merged commit 86b6fbf into avocado-framework-tests:master Mar 29, 2024
15 checks passed
@sacsant
Copy link
Contributor Author

sacsant commented Apr 1, 2024

@PraveenPenguin there is an issue with the last commit 3fc8e18. A comma is missing after 'userspace-rcu-devel'. Do you want me to send another fix or push this branch again to integrate updated code?

@sacsant sacsant deleted the xfstest branch April 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants